Update the default expected exception in server tests #12555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Nov 2, 2024
| void setupOptions() { | ||
| options.expectedServerSpanNameMapper = this::expectedServerSpanName; | ||
| options.expectedHttpRoute = this::expectedHttpRoute; | ||
| options.setExpectedException(new IllegalStateException(EXCEPTION.getBody())); |
Contributor
There was a problem hiding this comment.
any reason you didn't change this in
instead?
Member
Author
There was a problem hiding this comment.
I missed this when looking for where it was configured, i'll update
laurit
reviewed
Nov 2, 2024
| ) | ||
| // instrumentation does not create a span at all | ||
| options.disableTestNonStandardHttpMethod | ||
| options.setExpectedException( |
Contributor
There was a problem hiding this comment.
I'd just make the scala and grails tests also throw IllegalStateException. The only one tests that could keep using are the old groovy tests, they'll get converted eventually anyway.
laurit
approved these changes
Nov 2, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.